Document how to size the direct memory under expected event size #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nput to decode a batch of events.
andsel
force-pushed
the
fix/describe_how_to_size_direct_memory
branch
from
ab84f1a to
ecaf36a
Compare
…ine how many batch in flight we have, but the number of connected channels.
andsel
commented
Sep 25, 2023
|
|
||
| To correctly size the direct memory to sustain the flow of incoming Beats connections, the medium size of the transmitted | ||
| log lines and the batch size used by Beats (default to 2048), has to be known. For each connected client, a batch of events | ||
| is read and due to the way the decompressing and decoding part works, it keeps two copies of the batch in memory. |
There was a problem hiding this comment.
Note for reviewer:
Beats decoding part keeps 2 copies of the buffer it's processing in memory:
- one for the decompression:
logstash-input-beats/src/main/java/org/logstash/beats/BeatsParser.java
Lines 232 to 234 in 339913c
- the other is kep in the batch before lazily creating LogStash events:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Better document how this plugin allocates direct memory so that a better capacity planning can be applied.
Why is it important/What is the impact to the user?
The user, given some statistical measures, can determine if the sizing of direct memory is correct so that he can avoid potential out-of-memory errors in the direct memory.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding change to the default configuration files (and/or docker env variables)[ ] I have added tests that prove my fix is effective or that my feature works